-
Notifications
You must be signed in to change notification settings - Fork 43
Add iproto requests for stream transactions #2918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locker
reviewed
Jun 6, 2022
3 tasks
locker
approved these changes
Jun 6, 2022
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level | ||
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read committed, but not confirmed changes | ||
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read only confirmed changes | ||
- ``TXN_ISOLATION_BEST_EFFORD = 3`` -- determine isolation level automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: efford -> effort
patiencedaur
approved these changes
Jun 7, 2022
Comment on lines
+745
to
+748
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level (default value) | ||
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read changes that are committed but not confirmed yet | ||
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read confirmed changes | ||
- ``TXN_ISOLATION_BEST_EFFORT = 3`` -- determine isolation level automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level (default value) | |
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read changes that are committed but not confirmed yet | |
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read confirmed changes | |
- ``TXN_ISOLATION_BEST_EFFORT = 3`` -- determine isolation level automatically | |
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level (default value). | |
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read changes that are committed but not confirmed yet. | |
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read confirmed changes. | |
- ``TXN_ISOLATION_BEST_EFFORT = 3`` -- determine isolation level automatically. |
You can find the list punctuation rules in our style guide.
Co-authored-by: Dia Patience Daur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2402 #2922